fix: 1147 - notify comment author when someone reacts - #1161
Merged
Conversation
Adds a comment_reaction notification type that fires when someone reacts to a comment you authored, distinct from the existing event_comment/comment_reply notifications. Self-reactions and reaction removal (untoggle) don't notify.
Move TestReactionToggle out to test_event_comment_reactions.py. test_event_comments.py was 562 lines, over the agent-complexity hard limit.
leahpeker
marked this pull request as ready for review
July 24, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reacting to a comment on an event didn't notify the comment's author — the only comment-related notifications were for new top-level comments and replies. This adds a
comment_reactionnotification type, fired when a reaction is added (not removed) to a comment, excluding self-reactions.Closes #1147
Test plan
test_reaction_notifies_comment_author,test_self_reaction_does_not_notify,test_removing_reaction_does_not_notifyinbackend/tests/test_event_comments.pymake agent-lint,make agent-typecheck(backend)